<feed xmlns='http://www.w3.org/2005/Atom'>
<title>aerc/lib/format, branch shivesh</title>
<subtitle>A pretty good email client (shivesh branch)</subtitle>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/'/>
<entry>
<title>Implement interface for my custom IMAP flags</title>
<updated>2021-10-23T17:37:06+00:00</updated>
<author>
<name>Shivesh Mandalia</name>
<email>mail@shivesh.org</email>
</author>
<published>2021-10-23T17:37:06+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=5c7d4873908f28dde33013d10543e4cf1417525b'/>
<id>5c7d4873908f28dde33013d10543e4cf1417525b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>format: remove parse methods, use the one from go-message</title>
<updated>2020-11-14T14:40:13+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-11-10T19:35:47+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=24f1c575ae7941fa4239ec60bd86aef2f6641364'/>
<id>24f1c575ae7941fa4239ec60bd86aef2f6641364</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>compose: use a proper header instead of a string map</title>
<updated>2020-11-14T14:40:13+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-11-10T19:27:30+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=20ec2c8eeb2e071f28358814935a0f56672a9f49'/>
<id>20ec2c8eeb2e071f28358814935a0f56672a9f49</id>
<content type='text'>
Prior to this commit, the composer was based on a map[string]string.
While this approach was very versatile, it lead to a constant encoding / decoding
of addresses and other headers.

This commit switches to a different model, where the composer is based on a header.
Commands which want to interact with it can simply set some defaults they would
like to have. Users can overwrite them however they like.

In order to get access to the functions generating / getting the msgid go-message
was upgraded.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Prior to this commit, the composer was based on a map[string]string.
While this approach was very versatile, it lead to a constant encoding / decoding
of addresses and other headers.

This commit switches to a different model, where the composer is based on a header.
Commands which want to interact with it can simply set some defaults they would
like to have. Users can overwrite them however they like.

In order to get access to the functions generating / getting the msgid go-message
was upgraded.
</pre>
</div>
</content>
</entry>
<entry>
<title>remove models.Address in favor of go-message Address</title>
<updated>2020-11-14T14:40:13+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-11-10T18:57:09+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=fc9ccc30008e564c1dea23b3bfe480ca5a10c070'/>
<id>fc9ccc30008e564c1dea23b3bfe480ca5a10c070</id>
<content type='text'>
We made a new type out of go-message/mail.Address without any real reason.
This suddenly made it necessary to convert from one to the other without actually
having any benefit whatsoever.
This commit gets rid of the additional type
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We made a new type out of go-message/mail.Address without any real reason.
This suddenly made it necessary to convert from one to the other without actually
having any benefit whatsoever.
This commit gets rid of the additional type
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor ParseMessageFormat to use a ctx object</title>
<updated>2020-10-14T06:42:26+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-10-14T06:42:26+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=75cbf767326dfc67325773850ab1f6451dc9fb14'/>
<id>75cbf767326dfc67325773850ab1f6451dc9fb14</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix comment in ParseAddressList</title>
<updated>2020-09-10T05:35:56+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-09-10T05:33:28+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=504417b6709ba8ec74016ad00eaa7fcec9deb6ef'/>
<id>504417b6709ba8ec74016ad00eaa7fcec9deb6ef</id>
<content type='text'>
Go pre 1.15 parsed an empty string as an error, 1.15 did not but this was
unintentional as per https://github.com/golang/go/issues/40803

Fix the comment accordingly
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Go pre 1.15 parsed an empty string as an error, 1.15 did not but this was
unintentional as per https://github.com/golang/go/issues/40803

Fix the comment accordingly
</pre>
</div>
</content>
</entry>
<entry>
<title>ParseAddressList: return empty list if "" is provided</title>
<updated>2020-08-24T21:28:18+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-08-24T21:01:18+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=b6ef116c36e1a1de6a2289f392603fd51a2b91da'/>
<id>b6ef116c36e1a1de6a2289f392603fd51a2b91da</id>
<content type='text'>
Go 1.15 handles "" in the address parser as a non error case, returning
an empty list.
Prior versions returned an error, which is not what we want.

Reported-by: anianz &lt;a.ziegler@cioplenu.de&gt;
Tested-by: anianz &lt;a.ziegler@cioplenu.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Go 1.15 handles "" in the address parser as a non error case, returning
an empty list.
Prior versions returned an error, which is not what we want.

Reported-by: anianz &lt;a.ziegler@cioplenu.de&gt;
Tested-by: anianz &lt;a.ziegler@cioplenu.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Localize timestamps in the message list</title>
<updated>2020-08-22T08:32:02+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-08-21T06:46:25+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=eb1439c2417a7f85c80249d63821e10027d7d329'/>
<id>eb1439c2417a7f85c80249d63821e10027d7d329</id>
<content type='text'>
Not sure we need a flag for it, most people expect times to be in their local
time anyhow.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Not sure we need a flag for it, most people expect times to be in their local
time anyhow.
</pre>
</div>
</content>
</entry>
<entry>
<title>base models.Address on the mail.Address type</title>
<updated>2020-08-20T17:18:57+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-08-19T10:01:45+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=c84630714405a1e93766a6a6c023801302a3ea66'/>
<id>c84630714405a1e93766a6a6c023801302a3ea66</id>
<content type='text'>
This allows us to hook into the std libs implementation of parsing related stuff.
For this, we need to get rid of the distinction between a mailbox and a host
to just a single "address" field.

However this is already the common case. All but one users immediately
concatenated the mbox/domain to a single address.

So this in effects makes it simpler for most cases and we simply do the
transformation in the special case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows us to hook into the std libs implementation of parsing related stuff.
For this, we need to get rid of the distinction between a mailbox and a host
to just a single "address" field.

However this is already the common case. All but one users immediately
concatenated the mbox/domain to a single address.

So this in effects makes it simpler for most cases and we simply do the
transformation in the special case.
</pre>
</div>
</content>
</entry>
<entry>
<title>improve date parsing for notmuch/maildir</title>
<updated>2020-08-10T06:00:52+00:00</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-07-26T23:48:22+00:00</published>
<link rel='alternate' type='text/html' href='https://cgit.shivesh.org/aerc/commit/?id=f1a0fd20d6d30fb1203ffa3cb9f4004476acfdb3'/>
<id>f1a0fd20d6d30fb1203ffa3cb9f4004476acfdb3</id>
<content type='text'>
If a message date would fail to parse, the worker would never receive
the MessageInfo it asked for, and so it wouldn't display the message.

The problem is the spec for date formats is too lax, so trying to ensure
we can parse every weird date format out there is not a strategy we want
to pursue. On the other hand, preventing the user from reading and
working with a message due to the error format is also not a solution.

The maildir and notmuch workers will now fallback to the internal date, which
is based on the received header if we can't parse the format of the Date header.

The UI will also fallback to the received header whenever the date header can't
be parsed.

This patch is based on the work done by Lyudmil Angelov &lt;lyudmilangelov@gmail.com&gt;
But tries to handle a parsing error a bit more gracefully instead of just returning
the zero date.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a message date would fail to parse, the worker would never receive
the MessageInfo it asked for, and so it wouldn't display the message.

The problem is the spec for date formats is too lax, so trying to ensure
we can parse every weird date format out there is not a strategy we want
to pursue. On the other hand, preventing the user from reading and
working with a message due to the error format is also not a solution.

The maildir and notmuch workers will now fallback to the internal date, which
is based on the received header if we can't parse the format of the Date header.

The UI will also fallback to the received header whenever the date header can't
be parsed.

This patch is based on the work done by Lyudmil Angelov &lt;lyudmilangelov@gmail.com&gt;
But tries to handle a parsing error a bit more gracefully instead of just returning
the zero date.
</pre>
</div>
</content>
</entry>
</feed>
